This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Prepare monorepo for typescript migration #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svallory
suggested changes
May 20, 2023
| "name": "pug-monorepo", | ||
| "private": true, | ||
| "name": "madthax-pug-ts", |
There was a problem hiding this comment.
This is just the monorepo config. It is not a package, so it needs to remain private so we don't publish it by accident.
Also, npm will show the packages you published regardless of the organization they are in (check mine) so how about we name this @tokilabs/pug-ts (after the repository) and all other packages as @tokilabs/[original name]?
| "author": "Thassio Werlang <[email protected]>", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/madthax/pug-ts" |
There was a problem hiding this comment.
This needs to be the official repository https://github.com/tokilabs/pug-ts
svallory
changed the title
svallory
changed the title
svallory
changed the title
svallory
changed the title
|
Another thing @madthax you forgot to create a prettier configuration file that uses Also, in the future, update the issue's checklist as you make progress ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the changes from the first issue.
Closes #1